Modify

Ticket #95 (closed bug: fixed)

Opened 9 years ago

Last modified 9 years ago

When using the quit keyboard shorutcut sometimes mouse clicks will do nothing

Reported by: kaydeth_parpg Owned by: parpg
Priority: minor Milestone: Techdemo 1
Component: scripts Version: trunk
Keywords: Cc:
Blocked By: Blocking:
Department:

Description

How to Repeat: Open the Yes/No? quit prompt by pressing the quit keyboard shortcut (default is 'q'). Place the mouse pointer over the "No" option and click. This will cause the prompt to disappear. Without moving the mouse again, press the quit keyboard shortcut and click on "No" again. The "No" button will highlight but the prompt will not disappear.

Attachments

quit_and_main_menu.patch (3.4 KB) - added by Elie De Brauwer <elie@…> 9 years ago.
patch to fix the quit button issue, and to fix the main menu alignment
quit_and_main_menu.2.patch (3.4 KB) - added by Elie De Brauwer <elie@…> 9 years ago.
version 2
quit_and_main_menu.3.patch (3.4 KB) - added by Elie De Brauwer <elie@…> 9 years ago.
modified patch for 12 pixel fontsize

Change History

Changed 9 years ago by Elie De Brauwer <elie@…>

patch to fix the quit button issue, and to fix the main menu alignment

comment:1 Changed 9 years ago by Elie De Brauwer <elie@…>

In attachment there's a patch which will do two things:

-> the file gui/hud_main_menu.xml is extended with a comment to explain widget positions, but it also contains some updated widget sizes and positioning, this will cause all buttons on the main menu to have the same size (instead of looking like a centered mess as it does now). -> the file scripts/hud.py is modified, this will make the 'are you sure' popup larger than the current main menu, but this will also make sure the yes and no button are equal in size (now it looks as if the no button was hit by a car). The last thing changed was actually which fixes this issue, apparently the default callback (action event would be my guess) didn't get fired in the case described in this ticket. So now I added the same callback for the mouseclicked callback and this seems to fix this issue.

If the gui layout changes are unwanted all that is needed is the extra callback.

Changed 9 years ago by Elie De Brauwer <elie@…>

version 2

comment:2 Changed 9 years ago by Elie De Brauwer <elie@…>

version 2 is the correct version, the event should be triggered by the action and the mouseClicked (the mouseClicked in case the action doesn't fire). In my first patch I replaced the action by mouseClicked. But when you right click the yes button (select), then press left and then enter (artificial way to highlight the no and activate it) it wouldn't fire, since nobody clicked on it.

Changed 9 years ago by Elie De Brauwer <elie@…>

modified patch for 12 pixel fontsize

comment:3 Changed 9 years ago by Elie De Brauwer <elie@…>

Ticket #96 suggested to increase the fontsize to 12 pixels, this however would invalidate the 2nd version hence a third version where the main menu buttons have been enlarged to accomodate this change.

comment:4 Changed 9 years ago by Elie De Brauwer <elie@…>

The gui layout changes have been split to ticket #99. so the patches here are not longer relevant.

comment:5 Changed 9 years ago by eliedebrauwer

  • Status changed from new to closed
  • Resolution set to fixed

Fix has been applied in [294] which also fixes #99. Closing ticket.

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.