Modify ↓
Ticket #276 (closed enhancement: fixed)
Inconsistency between attributes and parameters in dialogueparsers.py
| Reported by: | Aspidites <aspidites@…> | Owned by: | technomage |
|---|---|---|---|
| Priority: | major | Milestone: | Release: Techdemo 2 |
| Component: | scripts | Version: | trunk |
| Keywords: | dialogueparser | Cc: | |
| Blocked By: | Blocking: | ||
| Department: |
Description (last modified by barra_parpg) (diff)
How to reproduce the bug
- Construct a new Dialogue object passing the dialogue_sections parameter
- Attempt to access the parameter (Dialogue.dialogue_sections)
Expected result
- Return a list of dialogue sections
Actual result
- AttributeError? is raised, as the actual attribute is called sections, not dialogue_sections
Fix
- Rename dialogue_actions in the init method to sections. Patch included.
- References to dialogue_sections also need to be changed to sections. Not included in the patch since I've made other modifications to the affected file which should not be published yet (dialogueparsers.py)
Attachments
Change History
Changed 8 years ago by Aspidites <aspidites@…>
- Attachment dialogue.patch added
comment:2 Changed 8 years ago by barra_parpg
- Keywords dialogueparser added
- Type changed from bug to enhancement
Note: See
TracTickets for help on using
tickets.
patch correcting discussed issue. affects dialogue.py