Modify

Ticket #129 (closed bug: fixed)

Opened 10 years ago

Last modified 10 years ago

Code cleanup: popups.py

Reported by: octavio <unix.logic@…> Owned by: parpg
Priority: trivial Milestone: Techdemo 1
Component: scripts Version: trunk
Keywords: Cc:
Blocked By: Blocking:
Department:

Description

In the ContainerGUI.setMouseCursor function, a variable is initialized as dummy_cursor_id and later referenced as target_dummy_cursor_id.

A parameter of the same function redefines the builtin type 'type'. Which breaks PEP 8 coding standards and is usually a bad idea anyway, so I changed it to mc_type in the patch. Also changed some spacing to comply with the standard.

Attachments

popups.py.diff (1.5 KB) - added by octavio <unix.logic@…> 10 years ago.
new_popups.py.diff (1.6 KB) - added by octavio <unix.logic@…> 10 years ago.

Change History

Changed 10 years ago by octavio <unix.logic@…>

Changed 10 years ago by octavio <unix.logic@…>

comment:1 Changed 10 years ago by octavio <unix.logic@…>

Fixed patch, remade it in the correct directory.

comment:2 Changed 10 years ago by eliedebrauwer

  • Status changed from new to closed
  • Resolution set to fixed

(In [344]) Ticket #129. Fix by octavio, PEP-8 code cleanup. closes #129

View

Add a comment

Modify Ticket

Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.